rkhachatryan commented on a change in pull request #15339:
URL: https://github.com/apache/flink/pull/15339#discussion_r602435951



##########
File path: flink-connectors/flink-connector-base/pom.xml
##########
@@ -64,5 +64,12 @@
                        <version>${project.version}</version>
                        <scope>test</scope>
                </dependency>
+
+               <dependency>
+                       <groupId>org.apache.flink</groupId>
+                       
<artifactId>flink-statebackend-changelog_${scala.binary.version}</artifactId>
+                       <version>${project.version}</version>
+                       <scope>test</scope>
+               </dependency>

Review comment:
       I'm wondering wether it makes sense to add this dependency at higher 
level (like `flink-connectors`). Top-level `pom.xml` will not work I guess as 
it will be a recursive dependency.
   
   Motivation:
   1. tests for the newly added connectors will not fail (after being added 
some random number of runs)
   2. less duplication
   
   WDYT? 
   
   cc: @AHeise 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to