wangyang0918 opened a new pull request #15396:
URL: https://github.com/apache/flink/pull/15396
<!--
*Thank you very much for contributing to Apache Flink - we are happy that
you want to help us improve Flink. To help the community review your
contribution in the best possible way, please go through the checklist below,
which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a
hassle. In order to uphold a high standard of quality for code contributions,
while at the same time managing a large number of contributions, we need
contributors to prepare the contributions well, and give reviewers enough
contextual information for the review. Please also understand that
contributions that do not follow this guide will take longer to review and thus
typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA
issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are
made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the
pull request", where *FLINK-XXXX* should be replaced by the actual issue
number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following
this pattern: `[hotfix] [docs] Fix typo in event time introduction` or
`[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the
pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean
verify` passes. You can set up Azure Pipelines CI to do that following [this
guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from
multiple issues.
- Each commit in the pull request has a meaningful commit message
(including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and
this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
In `ClusterEntrypoint#shutDownAsync`, we first call the
`closeClusterComponent`, which also includes deregistering the Flink
application from cluster management(e.g. Yarn, K8s). Then we call the
`stopClusterServices` and `cleanupDirectories`. Imagine that the cluster
management do the deregister very fast, the JobManager process receives SIGNAL
15 before or is being executing the `stopClusterServices` and
`cleanupDirectories`. The jvm process will directly exit then. So the
concurrent `shutDownAsync` may not be fully executed.
This PR introduce a shutdownSupplier for `SignalHandler`, which allows to
doing some clean up operations before handling the signal. In
`ClusterEntrypoint`, I just register a `completedVoidFuture`, which is guarded
by `lock`. It will ensure that the concurrent `shutDownAsync` could be fully
executed.
Why do you directly register `ClusterEntrypoint#closeAsync` as the
`shutdownSupplier`?
Because it will also deregister the Flink cluster from resource
management(e.g. Yarn, K8s). Of cause, it is not the intention of `SIGTERM.`
This PR also includes `hotfix` which makes the `closeAsync` will not clean
up the HA data. I think it is not a correct behavior. Once the
per-job/application cluster finished, it will call `shutDownAsync(.., ..,
true)` to clean up the HA data.
## Brief change log
* [hotfix][coordination] Do not clean up HA data when cluster entrypoint is
closed externally
* [FLINK-21008][coordination] Register a shutdown supplier in the
SignalHandler for ClusterEntrypoint
## Verifying this change
* Manually verified in the minikube with Flink application and HA enabled
* We could get the following code to ensure that the shutdownSupplier has
taken effect
* All other Yarn/Standalone tests should pass without changes
```
2021-03-28 06:59:14,175 INFO
org.apache.flink.kubernetes.highavailability.KubernetesHaServices [] - Finished
cleaning up the high availability data.
2021-03-28 06:59:14,186 INFO
org.apache.flink.runtime.rpc.akka.AkkaRpcService [] - Stopping Akka
RPC service.
2021-03-28 06:59:14,198 INFO
org.apache.flink.runtime.rpc.akka.AkkaRpcService [] - Stopping Akka
RPC service.
2021-03-28 06:59:14,228 INFO
akka.remote.RemoteActorRefProvider$RemotingTerminator [] - Shutting down
remote daemon.
2021-03-28 06:59:14,298 INFO
akka.remote.RemoteActorRefProvider$RemotingTerminator [] - Shutting down
remote daemon.
2021-03-28 06:59:14,299 INFO
akka.remote.RemoteActorRefProvider$RemotingTerminator [] - Remote daemon
shut down; proceeding with flushing remote transports.
2021-03-28 06:59:14,307 INFO
akka.remote.RemoteActorRefProvider$RemotingTerminator [] - Remote daemon
shut down; proceeding with flushing remote transports.
2021-03-28 06:59:14,419 INFO
akka.remote.RemoteActorRefProvider$RemotingTerminator [] - Remoting shut
down.
2021-03-28 06:59:14,422 INFO
akka.remote.RemoteActorRefProvider$RemotingTerminator [] - Remoting shut
down.
2021-03-28 06:59:14,473 INFO
org.apache.flink.runtime.rpc.akka.AkkaRpcService [] - Stopped Akka
RPC service.
2021-03-28 06:59:14,488 INFO
org.apache.flink.runtime.entrypoint.ClusterEntrypoint [] - Terminating
cluster entrypoint process KubernetesApplicationClusterEntrypoint with exit
code 0.
2021-03-28 06:59:14,489 INFO
org.apache.flink.runtime.rpc.akka.AkkaRpcService [] - Stopped Akka
RPC service.
```
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (**yes** / no /
don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
