zentol commented on a change in pull request #14945:
URL: https://github.com/apache/flink/pull/14945#discussion_r603063590



##########
File path: 
flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/pom.xml
##########
@@ -45,6 +45,7 @@ under the License.
        <properties>
                
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
                <flink.version>@project.version@</flink.version>
+               <target.java.version>@target.java.version@</target.java.version>

Review comment:
       Those are good suggestions and will help us down the line once we 
default to Java 11.
   
   Currently it still should've worked though; because the goal was to just get 
the scala compiler to work with java 8 instead of 6.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to