rkhachatryan commented on a change in pull request #15200:
URL: https://github.com/apache/flink/pull/15200#discussion_r603200933
##########
File path:
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/AbstractChangelogState.java
##########
@@ -34,10 +34,13 @@
abstract class AbstractChangelogState<K, N, V, S extends InternalKvState<K, N,
V>>
implements InternalKvState<K, N, V> {
protected final S delegatedState;
+ protected N currentNamespace;
+ protected KvStateChangeLogger<V, N> changeLogger;
- AbstractChangelogState(S state) {
+ AbstractChangelogState(S state, KvStateChangeLogger<V, N> changeLogger) {
Review comment:
I slightly prefer to mark nullable fields as such and assume everythin
else non-nullable.
But `Preconditions.notNull` check is missing. Do you think adding it is
enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
