dawidwys commented on a change in pull request #15221:
URL: https://github.com/apache/flink/pull/15221#discussion_r603222698
##########
File path: flink-runtime-web/src/test/resources/rest_api_v1.snapshot
##########
@@ -740,7 +740,7 @@
},
"status" : {
"type" : "string",
- "enum" : [ "CREATED", "SCHEDULED", "DEPLOYING", "RUNNING",
"FINISHED", "CANCELING", "CANCELED", "FAILED", "RECONCILING" ]
+ "enum" : [ "CREATED", "SCHEDULED", "DEPLOYING", "RECOVERING",
"RUNNING", "FINISHED", "CANCELING", "CANCELED", "FAILED", "RECONCILING" ]
Review comment:
I am not sure myself. @zentol WDYT?
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -825,7 +841,9 @@ private void doRun() {
while (true) {
Review comment:
please update the comment above
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/SchedulerTestingUtils.java
##########
@@ -224,16 +224,21 @@ public static void canceledExecution(
public static void setExecutionToRunning(
DefaultScheduler scheduler, JobVertexID jvid, int subtask) {
final ExecutionAttemptID attemptID = getAttemptId(scheduler, jvid,
subtask);
+ scheduler.updateTaskExecutionState(
Review comment:
Wouldn't it be better to have a separate `setExecutionToRecovering`? We
do not switch over multiple states in any of the other methods and it might be
surprising for future users of this class.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
##########
@@ -719,7 +721,9 @@ private void updatePartitionConsumers(final
IntermediateResultPartition partitio
// Consumer is deploying => cache the partition info which would be
// sent after switching to running
// ----------------------------------------------------------------
- if (consumerState == DEPLOYING || consumerState == RUNNING) {
+ if (consumerState == DEPLOYING
Review comment:
Do we need the `|| consumerState == RUNNING` here? Shouldn't we update
only when switching from `DEPLOYING` to `RECOVERING`?
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -505,6 +505,7 @@ AbstractInvokable getInvokable() {
public boolean isBackPressured() {
if (invokable == null
|| consumableNotifyingPartitionWriters.length == 0
+ || executionState != ExecutionState.RECOVERING
Review comment:
Shouldn't it be `|| (executionState != ExecutionState.RECOVERING &&
executionState != ExecutionState.RUNNING)`?
The way it is now, one of the two last conditions is always true. Can we add
a test for it if we don't have one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
