afedulov commented on a change in pull request #15054: URL: https://github.com/apache/flink/pull/15054#discussion_r603241292
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/stats/OperatorStatsTracker.java ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.webmonitor.stats; + +import org.apache.flink.runtime.executiongraph.AccessExecutionJobVertex; +import org.apache.flink.util.FlinkException; + +import java.util.Optional; + +/** + * Interface for a tracker of statistics for {@link AccessExecutionJobVertex}. + * + * @param <T> Type of statistics to track + */ +public interface OperatorStatsTracker<T extends Statistics> { Review comment: I actually think it is correct. We do sample individual tasks, but the tracker is responsible for assembling a combined view from them which represent an Operator (see `ThreadInfoOperatorTracker`). The main method of this interface returns such combined statistics representation for the vertex(operator): ``` Optional<T> getOperatorStats(AccessExecutionJobVertex vertex); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
