zhuzhurk commented on a change in pull request #15314:
URL: https://github.com/apache/flink/pull/15314#discussion_r603273083
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
##########
@@ -473,7 +473,7 @@ public void setInitialState(@Nullable JobManagerTaskRestore
taskRestore) {
private static int getPartitionMaxParallelism(
IntermediateResultPartition partition,
Function<ExecutionVertexID, ExecutionVertex> getVertexById) {
- final List<ConsumerVertexGroup> consumers = partition.getConsumers();
+ final List<ConsumerVertexGroup> consumers =
partition.getConsumerVertexGroups();
Review comment:
consumers -> consumerVertexGroups
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/PartitionDescriptor.java
##########
@@ -113,7 +113,7 @@ public static PartitionDescriptor
from(IntermediateResultPartition partition) {
// If no consumers are known at this point, we use a single
subpartition, otherwise we have
// one for each consuming sub task.
int numberOfSubpartitions = 1;
- List<ConsumerVertexGroup> consumers = partition.getConsumers();
+ List<ConsumerVertexGroup> consumers =
partition.getConsumerVertexGroups();
Review comment:
`consumers` -> `consumerVertexGroups`
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
##########
@@ -696,7 +696,7 @@ else if (current == RUNNING || current == DEPLOYING) {
private void updatePartitionConsumers(final IntermediateResultPartition
partition) {
- final List<ConsumerVertexGroup> allConsumers =
partition.getConsumers();
+ final List<ConsumerVertexGroup> allConsumers =
partition.getConsumerVertexGroups();
Review comment:
allConsumers -> consumerVertexGroups
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphTestUtils.java
##########
@@ -501,7 +501,7 @@ public static void verifyGeneratedExecutionJobVertex(
assertEquals(inputJobVertices.size(), ev.getNumberOfInputs());
for (int i = 0; i < inputJobVertices.size(); i++) {
- ConsumedPartitionGroup consumedPartitions =
ev.getConsumedPartitions(i);
+ ConsumedPartitionGroup consumedPartitions =
ev.getConsumedPartitionGroup(i);
Review comment:
`consumedPartitions` -> `consumedPartitionGroup`
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/PointwisePatternTest.java
##########
@@ -276,7 +276,7 @@ private void testConnections(
for (int vertexIndex = 0; vertexIndex <
target.getTaskVertices().length; vertexIndex++) {
ExecutionVertex ev = target.getTaskVertices()[vertexIndex];
- ConsumedPartitionGroup partitionIds = ev.getConsumedPartitions(0);
+ ConsumedPartitionGroup partitionIds =
ev.getConsumedPartitionGroup(0);
Review comment:
consumedPartitions -> consumedPartitionGroup
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/PointwisePatternTest.java
##########
@@ -192,7 +192,7 @@ private void testLowToHigh(int lowDop, int highDop) throws
Exception {
for (ExecutionVertex ev : target.getTaskVertices()) {
assertEquals(1, ev.getNumberOfInputs());
- ConsumedPartitionGroup consumedPartitions =
ev.getConsumedPartitions(0);
+ ConsumedPartitionGroup consumedPartitions =
ev.getConsumedPartitionGroup(0);
Review comment:
consumedPartitions -> consumedPartitionGroup
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/PointwisePatternTest.java
##########
@@ -129,7 +129,7 @@ public void testNTo7N() throws Exception {
for (ExecutionVertex ev : target.getTaskVertices()) {
assertEquals(1, ev.getNumberOfInputs());
- ConsumedPartitionGroup consumedPartitions =
ev.getConsumedPartitions(0);
+ ConsumedPartitionGroup consumedPartitions =
ev.getConsumedPartitionGroup(0);
Review comment:
consumedPartitions -> consumedPartitionGroup
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/PointwisePatternTest.java
##########
@@ -111,7 +111,7 @@ public void testNTo2N() throws Exception {
for (ExecutionVertex ev : target.getTaskVertices()) {
assertEquals(1, ev.getNumberOfInputs());
- ConsumedPartitionGroup consumedPartitions =
ev.getConsumedPartitions(0);
+ ConsumedPartitionGroup consumedPartitions =
ev.getConsumedPartitionGroup(0);
Review comment:
consumedPartitions -> consumedPartitionGroup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
