wuchong commented on a change in pull request #15412:
URL: https://github.com/apache/flink/pull/15412#discussion_r603766041
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/plan/logical/SliceAttachedWindowingStrategy.java
##########
@@ -46,12 +46,13 @@ public SliceAttachedWindowingStrategy(
@JsonProperty(value = FIELD_NAME_TIME_ATTRIBUTE_TYPE) LogicalType
timeAttributeType,
@JsonProperty(FIELD_NAME_SLICE_END) int sliceEnd) {
super(window, timeAttributeType);
+ checkArgument(sliceEnd >= 0);
this.sliceEnd = sliceEnd;
}
@Override
public String toSummaryString(String[] inputFieldNames) {
- checkArgument(sliceEnd >= 0 && sliceEnd < inputFieldNames.length);
+ checkArgument(sliceEnd < inputFieldNames.length);
Review comment:
No. This is not checked in constructor, the fieldNames is passed in this
method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
