dawidwys commented on a change in pull request #15313:
URL: https://github.com/apache/flink/pull/15313#discussion_r603870360
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/checkpointing/AbstractAlternatingAlignedBarrierHandlerAction.java
##########
@@ -74,9 +58,10 @@ public final BarrierHandlerAction barrierReceived(
context.triggerGlobalCheckpoint(checkpointBarrier);
state.unblockAllChannels();
return new AlternatingWaitingForFirstBarrier(state.getInputs());
- } else if (context.isTimedOut(checkpointBarrier)
- ||
checkpointBarrier.getCheckpointOptions().isUnalignedCheckpoint()) {
- return alignmentTimeout(context, checkpointBarrier);
+ } else if (context.isTimedOut(checkpointBarrier)) {
+ state.removeFromBlocked(channelInfo);
Review comment:
Your assumption is correct. The problem here is that we want the current
barrier to be handled by the subsequent state not the current one. That's why
we need to "revert" the state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
