XComp commented on pull request #15311: URL: https://github.com/apache/flink/pull/15311#issuecomment-810007628
The `JobMasterTest` failed due to a `NullPointerException` caused by me adding a notNull check to the `FailureHandlingResult` as part of my initial efforts to introduce `ErrorInfo` in `FailureHandlingResult` instead of dedicated members for the `failureCause` and `timestamp`. I reverted that change due to problems with the `SerializedThrowable` swallowing annotations that is necessary for [identifying non-recoverable errors](https://github.com/apache/flink/blob/c77a686c195d1742c276f4a9e75899c8b85377bb/flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/flip1/ExecutionFailureHandler.java#L140). I reverted the null check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
