AHeise commented on a change in pull request #15294:
URL: https://github.com/apache/flink/pull/15294#discussion_r603952155



##########
File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamConfig.java
##########
@@ -107,13 +107,20 @@
     private static final String TIME_CHARACTERISTIC = "timechar";
 
     private static final String MANAGED_MEMORY_FRACTION_PREFIX = 
"managedMemFraction.";
+
     private static final ConfigOption<Boolean> 
STATE_BACKEND_USE_MANAGED_MEMORY =
             ConfigOptions.key("statebackend.useManagedMemory")
                     .booleanType()
                     .noDefaultValue()
                     .withDescription(
                             "If state backend is specified, whether it uses 
managed memory.");
 
+    private static final ConfigOption<Boolean> SUPPORTS_UNALIGNED_INPUT =
+            ConfigOptions.key("unaligned_input")
+                    .booleanType()
+                    .defaultValue(true)
+                    .withDescription("Flag whether all input exchanges support 
unaligned input.");
+

Review comment:
       Changed it by using a forced aligned checkpoint. So not valid anymore.

##########
File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamingJobGraphGenerator.java
##########
@@ -686,6 +686,8 @@ private void setVertexConfig(
             }
         }
         config.setInputs(inputConfigs);
+        config.setSupportsUnalignedInput(
+                inEdges.isEmpty() || 
inEdges.get(0).supportsUnalignedCheckpoints());

Review comment:
       Changed it by using a forced aligned checkpoint. So not valid anymore.

##########
File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/checkpointing/AlignedController.java
##########
@@ -39,6 +40,8 @@
 /** Controller for aligned checkpoints. */
 @Internal
 public class AlignedController implements CheckpointBarrierBehaviourController 
{
+    private final boolean failOnUnalignedBarriers;

Review comment:
       Changed it by using a forced aligned checkpoint. So not valid anymore.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to