zicat commented on a change in pull request #15247:
URL: https://github.com/apache/flink/pull/15247#discussion_r603744434
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/join/temporal/TemporalRowTimeJoinOperator.java
##########
@@ -209,6 +209,7 @@ public void onEventTime(InternalTimer<Object,
VoidNamespace> timer) throws Excep
registerProcessingCleanupTimer();
} else {
cleanupLastTimer();
+ nextLeftIndex.clear();
Review comment:
When the program is going into line#211, that means leftState is empty
and rightState is empty after processing, so The author think the cleanup
trigger is meaningless and invoke the cleanupLastTimer() method to delete the
trigger(I guess). At this time, nextLeftIndexState is not
empty(registeredTimerState has been already cleanup because of line#201), the
nextLeftIndexState will be stored forever because cleanup trigger have been
deleted. @leonardBang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
