Thesharing opened a new pull request #15432:
URL: https://github.com/apache/flink/pull/15432


   ## What is the purpose of the change
   
   *We find that the BlockingQueue that used to preserve 
`TaskDeploymentDescriptor`s which are never used later. Since a 
`TaskDeploymentDescriptor` would cost massive heap memory, it may introduce 
unnecessary garbage collection and make the result of benchmarks related to 
deployment unstable. Therefore, we think it's better to remove the redundant 
blocking queue in `DeployingTasksBenchmarkBase`.*
   
   *For more details please check FLINK-22037.*
   
   
   ## Brief change log
   
     - *Remove the redundant `BlockingQueue` from `DeployingTasksBenchmarkBase`*
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / 
don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to