austince commented on a change in pull request #15348:
URL: https://github.com/apache/flink/pull/15348#discussion_r604400479
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveSchedulerTest.java
##########
@@ -119,6 +123,21 @@
public static final TestExecutorResource<ScheduledExecutorService>
TEST_EXECUTOR_RESOURCE =
new
TestExecutorResource<>(Executors::newSingleThreadScheduledExecutor);
+ @Parameterized.Parameters(name = "execution mode = {0}")
+ public static Object[] data() {
+ return new Object[] {SchedulerExecutionMode.REACTIVE, null};
Review comment:
I think it is enough to add the just targetted tests that you are
talking about, though I'd also like to add one to ensure that gets carried
through to the resource requests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
