kezhuw commented on a change in pull request #15425:
URL: https://github.com/apache/flink/pull/15425#discussion_r604601456
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceOperatorStreamTask.java
##########
@@ -97,6 +97,11 @@ public void init() throws Exception {
inputProcessor = new StreamOneInputProcessor<>(input, output,
operatorChain);
}
+ @Override
+ protected void finishTask() throws Exception {
+ stopMailboxProcessor();
Review comment:
I thought a bit about this. In normal path(same as no canceling path
currently), `cancelables.close` should be called after `afterInvoke` where
outputs are flushed, operators are closed/disposed. I believe
stop-with-savepoint belongs to normal path(at least no canceling path). So, I
tend to not call `cancelables.close` in `finishTask`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
