[
https://issues.apache.org/jira/browse/FLINK-22060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312104#comment-17312104
]
Matthias commented on FLINK-22060:
----------------------------------
We want to move the {{null}} handling out of the {{ExecutionGraph}}-related
code. That would enable FLINK-21376 to focus entirely on the {{Task}}-related
code.
> Move null handling from ErrorInfo into Task.notifyFinalState
> ------------------------------------------------------------
>
> Key: FLINK-22060
> URL: https://issues.apache.org/jira/browse/FLINK-22060
> Project: Flink
> Issue Type: Bug
> Reporter: Matthias
> Priority: Major
>
> Ideally, we would want to have this {{null}} check since a failure should
> always have a cause. We didn't introduce a null check so far because of
> FLINK-21376. There is [ErrorInfo.
> createErrorInfoWithNullableCause|https://github.com/apache/flink/blob/c77a686c195d1742c276f4a9e75899c8b85377bb/flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/ErrorInfo.java#L50]
> for handling this. But it feels to be handled in the wrong place. Instead,
> we should substitute the {{null}} value by the {{FlinkException}} in
> [Task.notifyFinalState|https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java#L1003].
> This way, we make sure that {{null}} never ends up in the
> {{ExecutionGraph}}-related code which enables us to make the invariants
> stricter on our end.
> This would serve as a preparation task
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
