[
https://issues.apache.org/jira/browse/FLINK-21999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312192#comment-17312192
]
Till Rohrmann commented on FLINK-21999:
---------------------------------------
Great, I've assigned you to this ticket now.
> The logic about whether Checkpoint is enabled.
> ----------------------------------------------
>
> Key: FLINK-21999
> URL: https://issues.apache.org/jira/browse/FLINK-21999
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Coordination
> Reporter: ZhangWei
> Assignee: ZhangWei
> Priority: Major
>
> org.apache.flink.runtime.executiongraph.DefaultExecutionGraphBuilder#isCheckpointingEnabled
> assumes checkpoint enabled when JobCheckpointingSettings is not null. While
> this is not enough, we must also guarantee the checkpoint interval is between
> [MINIMAL_CHECKPOINT_TIME, Long.MaxValue). That is like the
> JobGraph#isCheckpointingEnabled does.
> In current implement, when we do not set checkpoint interval, leaving it
> the default value -1, the interval will be changed to Long.MaxValue. Thus
> DefaultExecutionGraphBuilder#isCheckpointingEnabled will return true. That is
> not correct.
> in addition, there are different classes assume checkpoint enabled with
> different interval range.
> 1. CheckpointConfig -> (0,Long.MaxValue*]*.
> 2. JobGraph -> (0,Long.MaxValue)
> This is not consistent. And the correct range is [MINIMAL_CHECKPOINT_TIME,
> Long.MaxValue).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
