fsk119 commented on a change in pull request #15434:
URL: https://github.com/apache/flink/pull/15434#discussion_r604766842
##########
File path:
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/UpsertKafkaDynamicTableFactory.java
##########
@@ -155,6 +161,20 @@ public DynamicTableSink createDynamicTableSink(Context
context) {
Integer parallelism = tableOptions.get(FactoryUtil.SINK_PARALLELISM);
+ KafkaDynamicSink.SinkFunctionProviderCreator creator;
+ Duration interval = tableOptions.get(SINK_BUFFER_FLUSH_INTERVAL);
+ Integer batchSize = tableOptions.get(SINK_BUFFER_FLUSH_MAX_ROWS);
+ if (batchSize > 0 && interval.toMillis() > 0) {
Review comment:
Solved.
Add validation in TableFactory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
