[
https://issues.apache.org/jira/browse/FLINK-3777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15245438#comment-15245438
]
Fabian Hueske commented on FLINK-3777:
--------------------------------------
Would be great if you could open a PR for this issue. The
{{closeInputFormat()}} method can only be added with an empty default
implementation to {{RichInputFormat}} because {{InputFormat}} is an interface.
If we would add it to {{InputFormat}}, we would break all classes that
implement the interface.
Regarding API suggestions for Flink 2.0, I would reach out to the dev ML to
discuss how to record them. An alternative to JIRA could be a wiki page to
collect suggestions.
Thanks, Fabian
> Add open and close methods to manage IF lifecycle
> -------------------------------------------------
>
> Key: FLINK-3777
> URL: https://issues.apache.org/jira/browse/FLINK-3777
> Project: Flink
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.0.1
> Reporter: Flavio Pompermaier
> Labels: inputformat, lifecycle
>
> At the moment the opening and closing of an inputFormat are not managed,
> although open() could be (improperly IMHO) simulated by configure().
> This limits the possibility to reuse expensive resources (like database
> connections) and manage their release.
> Probably the best option would be to add 2 methods (i.e. openInputformat()
> and closeInputFormat() ) to RichInputFormat*
> * NOTE: the best option from a "semantic" point of view would be to rename
> the current open() and close() to openSplit() and closeSplit() respectively
> while using open() and close() methods for the IF lifecycle management, but
> this would cause a backward compatibility issue...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
