akalash commented on a change in pull request #15375:
URL: https://github.com/apache/flink/pull/15375#discussion_r604881603
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/MailboxProcessor.java
##########
@@ -183,27 +198,34 @@ public void runMailboxLoop() throws Exception {
final MailboxController defaultActionContext = new
MailboxController(this);
- while (isMailboxLoopRunning()) {
+ while (isNotSuspended()) {
// The blocking `processMail` call will not return until default
action is available.
processMail(localMailbox, false);
- if (isMailboxLoopRunning()) {
+ if (isNotSuspended()) {
Review comment:
I agree that it will be better to have isLoopRunning(or similar). Maybe
we indeed rename the old mailboxLoopRunning to mailboxActive(along with
method). And new suspended variable rename to loopRunning(or
mailboxLoopRunning)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
