twalthr commented on a change in pull request #15428:
URL: https://github.com/apache/flink/pull/15428#discussion_r604981686



##########
File path: 
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/planner/sources/DynamicSourceUtils.java
##########
@@ -155,6 +245,117 @@ public static boolean isSourceChangeEventsDuplicate(
 
     // 
--------------------------------------------------------------------------------------------
 
+    /** Creates a specialized node for assigning watermarks. */
+    private static void pushWatermarkAssigner(FlinkRelBuilder relBuilder, 
ResolvedSchema schema) {
+        final ExpressionConverter converter = new 
ExpressionConverter(relBuilder);
+        final RelDataType inputRelDataType = relBuilder.peek().getRowType();
+
+        final WatermarkSpec watermarkSpec = schema.getWatermarkSpecs().get(0);

Review comment:
       This is checked during schema resolution in 
`org.apache.flink.table.catalog.DefaultSchemaResolver#resolveWatermarkSpecs`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to