Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1899#discussion_r60047518
--- Diff:
flink-libraries/flink-gelly-examples/src/test/java/org/apache/flink/graph/library/TriangleEnumeratorITCase.java
---
@@ -47,10 +47,11 @@ public void testTriangleEnumerator() throws Exception
{
env);
List<Tuple3<Long,Long,Long>> actualOutput = graph.run(new
TriangleEnumerator<Long, NullValue, NullValue>()).collect();
- List<Tuple3<Long,Long,Long>> expectedResult =
TriangleCountData.getListOfTriangles();
+ List<Tuple3<Long,Long,Long>> expectedResult =
TriangleCountData.getListOfTriangles();
- Assert.assertEquals(actualOutput.size(), expectedResult.size());
+ Assert.assertEquals(expectedResult.size(), actualOutput.size());
for(Tuple3<Long,Long,Long> resultTriangle:actualOutput) {
+ System.out.println(resultTriangle);
--- End diff --
Do we need to print the result? We try to avoid printing from tests unless
it's absolutely necessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
