AHeise commented on a change in pull request #15054: URL: https://github.com/apache/flink/pull/15054#discussion_r605106839
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/ThreadInfoSampleService.java ########## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.flink.runtime.taskexecutor; + +import org.apache.flink.api.common.time.Time; +import org.apache.flink.runtime.concurrent.ScheduledExecutor; +import org.apache.flink.runtime.messages.ThreadInfoSample; +import org.apache.flink.runtime.util.JvmUtils; +import org.apache.flink.runtime.webmonitor.threadinfo.ThreadInfoSamplesRequest; + +import java.util.ArrayList; +import java.util.List; +import java.util.Optional; +import java.util.concurrent.CompletableFuture; + +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** Samples thread infos of tasks. */ +class ThreadInfoSampleService { + + private final ScheduledExecutor scheduledExecutor; + + ThreadInfoSampleService(final ScheduledExecutor scheduledExecutor) { + this.scheduledExecutor = + checkNotNull(scheduledExecutor, "scheduledExecutor must not be null"); + } + + /** + * Returns a future that completes with a given number of thread info samples of a task thread. + * + * @param task The task to be sampled from. + * @param requestParams Parameters of the sampling request. + * @return A future containing the stack trace samples. + */ + public CompletableFuture<List<ThreadInfoSample>> requestThreadInfoSamples( + final SampleableTask task, final ThreadInfoSamplesRequest requestParams) { + checkNotNull(task, "task must not be null"); + checkNotNull(requestParams, "requestParams must not be null"); + + return requestThreadInfoSamples( + task, + requestParams.getNumSamples(), + requestParams.getDelayBetweenSamples(), + requestParams.getMaxStackTraceDepth(), + new ArrayList<>(requestParams.getNumSamples()), + new CompletableFuture<>()); + } + + private CompletableFuture<List<ThreadInfoSample>> requestThreadInfoSamples( + final SampleableTask task, + final int numSamples, + final Time delayBetweenSamples, + final int maxStackTraceDepth, + final List<ThreadInfoSample> currentTraces, + final CompletableFuture<List<ThreadInfoSample>> resultFuture) { + + final long threadId = task.getExecutingThread().getId(); + final Optional<ThreadInfoSample> threadInfoSample = + JvmUtils.createThreadInfoSample(threadId, maxStackTraceDepth); + + if (threadInfoSample.isPresent()) { + currentTraces.add(threadInfoSample.get()); + } else if (!currentTraces.isEmpty()) { + resultFuture.complete(currentTraces); + return resultFuture; + } else { + throw new IllegalStateException( Review comment: Added it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org