wangyang0918 commented on a change in pull request #15407:
URL: https://github.com/apache/flink/pull/15407#discussion_r605371557
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
##########
@@ -509,6 +509,11 @@ public void disconnectTaskManager(final ResourceID
resourceId, final Exception c
@Override
public void disconnectJobManager(
final JobID jobId, JobStatus jobStatus, final Exception cause) {
+
+ if (jobStatus.isGloballyTerminalState()) {
Review comment:
Yes. The only difference is we also check the existence in
`jobManagerRegistrations` when `jobStatus` is globally terminal. And it is
reasonable doing that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
