tillrohrmann commented on a change in pull request #15396:
URL: https://github.com/apache/flink/pull/15396#discussion_r605459052
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/util/SignalHandler.java
##########
@@ -53,6 +63,13 @@ public void handle(Signal signal) {
"RECEIVED SIGNAL {}: SIG{}. Shutting down as requested.",
signal.getNumber(),
signal.getName());
+ try {
+ shutdownSupplier
+ .get()
+ .get(SHUTDOWN_TIMEOUT.toMilliseconds(),
TimeUnit.MILLISECONDS);
Review comment:
I think you are right that the `SignalHandler` only reacts to "TERM",
"HUP", "INT". I think I would still prefer a shut down hook because it seems
more designed for cleanup purposes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
