[ 
https://issues.apache.org/jira/browse/FLINK-3774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15245871#comment-15245871
 ] 

ASF GitHub Bot commented on FLINK-3774:
---------------------------------------

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/1904

    [FLINK-3774] [shell] Forwards Flink configuration to PlanExecutor

    Thanks for contributing to Apache Flink. Before you open your pull request, 
please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your 
pull request. For more information and/or questions please refer to the [How To 
Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful 
description of your changes.
    
    - [X] General
      - The pull request references the related JIRA issue
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message
    
    - [X] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [X] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis 
build has passed
    
    The ScalaShellRemoteEnvironment did not properly forward the given Flink 
configuration
    to the PlanExecutor. Consequently, it was not possible to configure the 
Client to connect
    to an HA cluster. This PR corrects the forwarding.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixScalaShell

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1904.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1904
    
----
commit 427fe789dcd20ba94dc9cebcef85b629ada6ce9c
Author: Till Rohrmann <[email protected]>
Date:   2016-04-18T15:41:47Z

    [FLINK-3774] [shell] Forwards Flink configuration to PlanExecutor
    
    The ScalaShellRemoteEnvironment did not properly forward the given Flink 
configuration
    to the PlanExecutor. Consequently, it was not possible to configure the 
Client to connect
    to an HA cluster. This PR corrects the forwarding.

----


> Flink configuration is not correctly forwarded to PlanExecutor in 
> ScalaShellRemoteEnvironment
> ---------------------------------------------------------------------------------------------
>
>                 Key: FLINK-3774
>                 URL: https://issues.apache.org/jira/browse/FLINK-3774
>             Project: Flink
>          Issue Type: Bug
>          Components: Scala Shell
>    Affects Versions: 1.1.0
>            Reporter: Till Rohrmann
>            Assignee: Andrea Sella
>            Priority: Minor
>             Fix For: 1.1.0
>
>
> Currently, the {{ScalaShellRemoteEnvironment}} does not correctly forwards 
> the Flink configuration to the {{PlanExecutor}}. Therefore, it is not 
> possible to use the Scala shell in combination with an HA cluster which needs 
> the configuration parameters set in the configuration.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to