[GitHub] [flink] YuvalItzchakov commented on a change in pull request #15307: [FLINK-21675][table-planner-blink] Allow Predicate Pushdown with Watermark Assigner Between Filter and Scan

[GitBox]

YuvalItzchakov commented on a change in pull request #15307:
URL: https://github.com/apache/flink/pull/15307#discussion_r606178436



##########
File path: 
flink-table/flink-table-planner-blink/src/test/java/org/apache/flink/table/planner/factories/TestValuesTableFactory.java
##########
@@ -923,6 +924,7 @@ private TestValuesScanTableSourceWithWatermarkPushDown(
                 Map<Map<String, String>, Collection<Row>> data,
                 String tableName,
                 boolean nestedProjectionSupported,
+                boolean bounded,

Review comment:
       I thought I needed this to test the Watermark + Pushdown mechanism but 
turns out I don't. Will revert.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org