fsk119 edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812484309
> @fsk119 I'm confused with all the suggestions. Should I keep working off this branch but have this as a logical rewrite instead? Are all the comments you left above still valid? > > If I instead take the code implemented by your PR, there's no need for the reusable base class here, so I want to know which one it is :) hi. @YuvalItzchakov . Please ignore the comments about code. I think you should take the code from my PR. I think optimization cannot break semantics but the current implementation does not. It will generate watermark for the records that meet the conditions . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
