fsk119 commented on pull request #15307:
URL: https://github.com/apache/flink/pull/15307#issuecomment-812492176


   > > > @fsk119 I see you also added a test for partition pushdown, are those 
related?
   > > 
   > > 
   > > Not related. I just try to find why the change breaks the test.
   > > It will try to apply filter push down first and then apply partition 
push down in the origin test and add `filter = []` into the digest. But the 
change in the PR will delay the filter push down, which means it will first 
apply partition push down and then filter push down. After the partition push 
down applies, we don't need to push the filter any more, which causes the 
disgest is different with before.
   > 
   > Does it still break after the new change you proposed?
   
   Yes. You can pull the code, go to the directy 
flink-table/flink-table-planner-blink and use the 
   ```
   mvn verify
   ```
   to test in local environment.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to