YuvalItzchakov edited a comment on pull request #15307: URL: https://github.com/apache/flink/pull/15307#issuecomment-812503994
> > @YuvalItzchakov . I think the added test is not enough to cover all. > > I think you should also need to add end to end Tests in the `org.apache.flink.table.planner.runtime.stream.sql.CalcITCase` and `org.apache.flink.table.planner.plan.stream.sql.CalcTest` to verify the added rule doesn't have conflcts with others. > > The test is not enough in my code. Please add more tests like I mentioned before. OK, I see what you're saying. Is there a reason though that the `FlinkLogicalCalc` is being generated twice? Do you think we can get this into 1.13? This is a critical fix for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
