Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1908#discussion_r60186786
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobCache.java ---
@@ -200,10 +200,14 @@ public void delete(BlobKey key) throws IOException{
* @param key referring to the file to be deleted
*/
public void deleteGlobal(BlobKey key) throws IOException {
- delete(key);
BlobClient bc = createClient();
- bc.delete(key);
- bc.close();
+ delete(key);
--- End diff --
BlobCache.delete can throw IOException (although right now it doesn't) and
then `bc` is not closed again. Maybe move it up again and then it should be
fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
