[
https://issues.apache.org/jira/browse/FLINK-3781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15247338#comment-15247338
]
ASF GitHub Bot commented on FLINK-3781:
---------------------------------------
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/1908#discussion_r60186786
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobCache.java ---
@@ -200,10 +200,14 @@ public void delete(BlobKey key) throws IOException{
* @param key referring to the file to be deleted
*/
public void deleteGlobal(BlobKey key) throws IOException {
- delete(key);
BlobClient bc = createClient();
- bc.delete(key);
- bc.close();
+ delete(key);
--- End diff --
BlobCache.delete can throw IOException (although right now it doesn't) and
then `bc` is not closed again. Maybe move it up again and then it should be
fine.
> BlobClient may be left unclosed in BlobCache#deleteGlobal()
> -----------------------------------------------------------
>
> Key: FLINK-3781
> URL: https://issues.apache.org/jira/browse/FLINK-3781
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Priority: Minor
>
> {code}
> public void deleteGlobal(BlobKey key) throws IOException {
> delete(key);
> BlobClient bc = createClient();
> bc.delete(key);
> bc.close();
> {code}
> If delete() throws IOException, BlobClient would be left inclosed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
