Github user StefanRRichter commented on the pull request:

    https://github.com/apache/flink/pull/1905#issuecomment-211819580
  
    Thanks Ufuk! I just saw that the build actually failed and it seems to me 
that the problem is indeed related to removing the dependency to asm from the 
pom.xml as Robert suggested? So I could either add the dependency again or do 
you see any option to solve this otherwise?
    
    There is one remaining question that I already started to discuss with Till 
about the select functions in PatternStream. The Java API wants to call them 
with java.util.Map as parameters, but I don't think we want Java classes in our 
Scala API. Currently I see two options how to change this without touching the 
Java API:
    
    1) Use Scala mutable.Map and automatic conversion.
    2) Use Scala immutable.Map and explicit conversion. From how I interpret 
the actual use of the Map in this function, the semantics are actually that of 
an immutable map.
    
    If the impact of the conversion is not an issue, I have already implemented 
version 2 (it is currently commented out in favor of a version that still uses 
Java Map. 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to