Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1910#issuecomment-211847621
Great addition to have a producer to Kinesis. The changes look good
overall, I had some minor inline comments.
The main concern is that we can only test this with a real Kinesis setup,
which makes it fragile for future changes etc. Did you consider trying to mock
the `KinesisProducer` to test that the expected calls are issued to it?
PS: The title of the JIRA issue and this PR is confusing (the last `...
into Flink` part)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
