wangyang0918 commented on a change in pull request #15396:
URL: https://github.com/apache/flink/pull/15396#discussion_r608777149
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java
##########
@@ -165,7 +165,7 @@ protected ClusterEntrypoint(Configuration configuration) {
shutDownHook =
ShutdownHookUtil.addShutdownHook(
- this::cleanupDirectories, getClass().getSimpleName(),
LOG);
+ () -> this.closeAsync().join(),
getClass().getSimpleName(), LOG);
Review comment:
IIUC, you are suggesting to add a unit test to guard the `closeAsync()`
is executed in the `shutdownHook`. Right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
