kezhuw commented on a change in pull request #15507:
URL: https://github.com/apache/flink/pull/15507#discussion_r608799934
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
##########
@@ -1096,12 +1096,7 @@ private StateBackend loadStateBackend(ReadableConfig
configuration, ClassLoader
// must not have null elements and mixed elements
FromElementsFunction.checkCollection(data, typeInfo.getTypeClass());
- SourceFunction<OUT> function;
- try {
- function = new
FromElementsFunction<>(typeInfo.createSerializer(getConfig()), data);
- } catch (IOException e) {
- throw new RuntimeException(e.getMessage(), e);
- }
+ SourceFunction<OUT> function = new FromElementsFunction<>(data);
Review comment:
Add `StreamExecutionEnvironmentTest
.testFromElementsPostConstructionType`.
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
##########
@@ -1096,12 +1096,7 @@ private StateBackend loadStateBackend(ReadableConfig
configuration, ClassLoader
// must not have null elements and mixed elements
FromElementsFunction.checkCollection(data, typeInfo.getTypeClass());
- SourceFunction<OUT> function;
- try {
- function = new
FromElementsFunction<>(typeInfo.createSerializer(getConfig()), data);
- } catch (IOException e) {
- throw new RuntimeException(e.getMessage(), e);
- }
+ SourceFunction<OUT> function = new FromElementsFunction<>(data);
Review comment:
Add
`StreamExecutionEnvironmentTest.testFromElementsPostConstructionType`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
