Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1904#discussion_r60217702
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/RemoteEnvironment.java ---
@@ -133,26 +137,31 @@ public RemoteEnvironment(String host, int port,
Configuration clientConfig,
this.port = port;
this.clientConfiguration = clientConfig == null ? new
Configuration() : clientConfig;
if (jarFiles != null) {
- this.jarFiles = new URL[jarFiles.length];
+ this.jarFiles = new ArrayList<URL>(jarFiles.length);
for (int i = 0; i < jarFiles.length; i++) {
try {
- this.jarFiles[i] = new
File(jarFiles[i]).getAbsoluteFile().toURI().toURL();
+ this.jarFiles.add(new
File(jarFiles[i]).getAbsoluteFile().toURI().toURL());
} catch (MalformedURLException e) {
throw new IllegalArgumentException("JAR
file path invalid", e);
}
}
}
else {
- this.jarFiles = null;
+ this.jarFiles = Collections.emptyList();
+ }
+
+ if (globalClasspaths == null) {
+ this.globalClasspaths = Collections.emptyList();
+ } else {
+ this.globalClasspaths = Arrays.asList(globalClasspaths);
}
- this.globalClasspaths = globalClasspaths;
}
//
------------------------------------------------------------------------
@Override
public JobExecutionResult execute(String jobName) throws Exception {
- ensureExecutorCreated();
+ PlanExecutor executor = getExecutor();
--- End diff --
would it make sense to move the assignment to ```this.executor``` from
```getExecutor()``` to this line? as it stands the ScalaShellRemoteEnvironment
executor is never closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
