Thesharing commented on pull request #15500: URL: https://github.com/apache/flink/pull/15500#issuecomment-815435726
> Thanks for creating this PR @Thesharing. I think the change looks good to me. > > Before merging this PR we should add a test which ensures the correct computation of the cross-region `ConsumedPartitionGroups`. This will help us to not break this functionality. Would such a test be possible to add @Thesharing? Thank you so much, @tillrohrmann. I've added two test cases for the computation of cross-region `ConsumedPartitionGroup`s. The first one makes sure that cross-region `ConsumedPartitionGroup`s are calculated correctly in the graph illustrated in FLINK-22017. The second one makes sure that there's no cross-region `ConsumedPartitionGroup` for all-to-all blocking edges. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
