Myasuka commented on a change in pull request #15395:
URL: https://github.com/apache/flink/pull/15395#discussion_r609310327
##########
File path:
flink-core/src/test/java/org/apache/flink/api/common/state/StateTtlConfigTest.java
##########
@@ -71,4 +74,22 @@ public void testStateTtlConfigBuildWithCleanupInBackground()
{
assertThat(incrementalCleanupStrategy.runCleanupForEveryRecord(),
is(false));
assertThat(rocksdbCleanupStrategy.getQueryTimeAfterNumEntries(),
is(1000L));
}
+
+ @Test
+ public void testStateTtlConfigBuildWithNonPositiveCleanupIncrementalSize()
{
+ ArrayList<Integer> illegalCleanUpSizes = new ArrayList<Integer>();
+ illegalCleanUpSizes.add(0);
+ illegalCleanUpSizes.add(-2);
Review comment:
Generally, I prefer to use `List<Integer> illegalCleanUpSizes =
Arrays.asList(0, -2);` to create the candidate list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
