wuchong commented on a change in pull request #15519: URL: https://github.com/apache/flink/pull/15519#discussion_r609395228
########## File path: flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/CalcITCase.scala ########## @@ -363,4 +363,28 @@ class CalcITCase extends StreamingTestBase { List("1,HI,1111,true,111","2,HELLO,2222,false,222", "3,HELLO WORLD,3333,true,333") assertEquals(expected.sorted, sink.getAppendResults.sorted) } + + @Test + def testMapGet(): Unit = { Review comment: The fix looks good to me, however, I would suggest to add tests to `org.apache.flink.table.planner.expressions.MapTypeTest`. An integeration test is much heavier than unit test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org