dawidwys opened a new pull request #15550:
URL: https://github.com/apache/flink/pull/15550


   ## What is the purpose of the change
   
   This PR reenables the JobMasterStopWithSavepointIT and adjusts the test so 
that it passes with changes that happened since it was last run.  
   
   Moreover in the course of debugging the test I realized the result of 
`Task#triggerCheckpointAsync` is ignored. I added a hotfix commit that fixes 
it. I considered two ways of fixing it.
   1. Changing the result type to `void`
   2. Actually returning the future
   I decided against option 1. because of the logic in 
`MultipleInputStreamTask`. So far the whole logic there has been ignored. If 
that's ok, we could remove it and change the return type to void.
   
   ## Verifying this change
   
   All tests work including `JobMasterStopWithSavepointITCase`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (**yes** / no / 
don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to