kezhuw commented on a change in pull request #15550:
URL: https://github.com/apache/flink/pull/15550#discussion_r610720272
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
##########
@@ -932,9 +932,9 @@ public void heartbeatFromResourceManager(ResourceID
resourceID) {
final Task task = taskSlotTable.getTask(executionAttemptID);
if (task != null) {
- task.triggerCheckpointBarrier(checkpointId, checkpointTimestamp,
checkpointOptions);
-
- return CompletableFuture.completedFuture(Acknowledge.get());
+ return task.triggerCheckpointBarrier(
+ checkpointId, checkpointTimestamp,
checkpointOptions)
+ .thenApply(result -> Acknowledge.get());
Review comment:
> Given the above and that the result is still ignored in
RpcTaskManagerGateway, I'm a bit skeptical of returning the future through the
call chain.
If the result is respected in that side, then the whole call chain will fail
due to rpc timeout(defaults to 10s). I guess it is not desired as it will
interfere with checkpoint timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
