KurtYoung commented on a change in pull request #15562:
URL: https://github.com/apache/flink/pull/15562#discussion_r611472404
##########
File path:
flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliTableauResultView.java
##########
@@ -132,11 +145,23 @@ private void printResults(AtomicInteger receivedRowCount,
boolean isStreamingMod
DEFAULT_COLUMN_WIDTH,
PrintUtils.NULL_COLUMN,
PrintUtils.ROW_KIND_COLUMN);
+ isEndOfStream = getEndOfStreamWhenRetrieveRows(change);
Review comment:
I know this, the logic you mentioned is already taken care by the codes
you modified before (which only has one while loop). What I don't understand is
why you split the old while loop and spread the logic of retrieving data into
3-5 places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
