[ 
https://issues.apache.org/jira/browse/FLINK-22144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17319427#comment-17319427
 ] 

Dawid Wysakowicz edited comment on FLINK-22144 at 4/12/21, 12:33 PM:
---------------------------------------------------------------------

Overall very good job! I really like the feature. I had two nitpicking 
comments. Let me know [~mapohl] if they make sense and if I should create 
tickets for them.
 * I wonder if we should put the configuration parameter in theĀ {{web.*}} 
section, similarly to {{web.checkpoints.history and {{web.history}}}}
 * 
[https://ci.apache.org/projects/flink/flink-docs-master/docs/deployment/config/#basic-setup]
 add the config option to "Web UI" section or "Other". Right now it's rather 
hard to find. At the same time I think it might be configured relatively often.
 * I really like the note "_The exception history is limited to the most recent 
failures that caused parts of the job or the entire job to restart. The maximum 
history size can be configured through the Flink configuration._" However could 
we mention the particular setting or link to it?


was (Author: dawidwys):
Overall very good job! I really like the feature. I had two nitpicking 
comments. Let me know [~mapohl] if they make sense and if I should create 
tickets for them.
 * I wonder if we should put the configuration parameter in theĀ {{web.*}} 
section, similarly to {{web.checkpoints.history}}
 * 
[https://ci.apache.org/projects/flink/flink-docs-master/docs/deployment/config/#basic-setup]
 add the config option to "Web UI" section or "Other". Right now it's rather 
hard to find. At the same time I think it might be configured relatively often.
 * I really like the note "_The exception history is limited to the most recent 
failures that caused parts of the job or the entire job to restart. The maximum 
history size can be configured through the Flink configuration._" However could 
we mention the particular setting or link to it?

> Test display last n exceptions/causes for job restarts in Web UI
> ----------------------------------------------------------------
>
>                 Key: FLINK-22144
>                 URL: https://issues.apache.org/jira/browse/FLINK-22144
>             Project: Flink
>          Issue Type: Test
>          Components: Runtime / Coordination
>    Affects Versions: 1.13.0
>            Reporter: Till Rohrmann
>            Assignee: Dawid Wysakowicz
>            Priority: Blocker
>              Labels: release-testing
>             Fix For: 1.13.0
>
>
> This is the testing task for FLINK-6042. We should test whether the root 
> causes for multiple restarts are properly displayed in the web UI.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to