Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1905#issuecomment-212429457
Thanks for your good contribution @StefanRRichter. I had some inline
comments.
It would be good to revisit the link tags in the ScalaDocs and replace them
with the ScalaDoc link syntax. I haven't marked all occurrences in the code.
Furthermore, it should be possible to completely throw out the `ClassTag`
context bound. I have only marked the first occurrences where I've noticed it.
The Scala code contained several lines which exceeded the maximum line
length of 100 characters. The Scala style check plugin, which detects these
style violations, is executed when you run `mvn verify`. Thus, it is always a
good idea to run `mvn verify` once locally before pushing commits to a PR.
Ping me once you've addressed my comments. Then I'll make sure that the PR
is merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
