dawidwys commented on a change in pull request #14834:
URL: https://github.com/apache/flink/pull/14834#discussion_r608746391
##########
File path: flink-end-to-end-tests/run-nightly-tests.sh
##########
@@ -32,30 +32,20 @@ if [ -z "$FLINK_DIR" ] ; then
exit 1
fi
+if [ -z "$FLINK_LOG_DIR" ] ; then
+ export FLINK_LOG_DIR="$FLINK_DIR/logs"
+fi
+
source "${END_TO_END_DIR}/../tools/ci/maven-utils.sh"
source "${END_TO_END_DIR}/test-scripts/test-runner-common.sh"
# On Azure CI, set artifacts dir
-if [ ! -z "$TF_BUILD" ] ; then
- export ARTIFACTS_DIR="${END_TO_END_DIR}/artifacts"
- mkdir -p $ARTIFACTS_DIR || { echo "FAILURE: cannot create log directory
'${ARTIFACTS_DIR}'." ; exit 1; }
-
- function run_on_exit {
- collect_coredumps $(pwd) $ARTIFACTS_DIR
- collect_dmesg $ARTIFACTS_DIR
- compress_logs
- }
-
- # compress and register logs for publication on exit
- function compress_logs {
Review comment:
I think it is safe to remove the manual compression as it is done
automatically by azure:
without manual compression:
```
Content upload statistics:
Total Content: 116.6 MB
Physical Content Uploaded: 7.0 MB
Logical Content Uploaded: 58.3 MB
Compression Saved: 51.3 MB
Deduplication Saved: 58.3 MB
Number of Chunks Uploaded: 593
```
with manual compression:
```
Content upload statistics:
Total Content: 14.0 MB
Physical Content Uploaded: 6.6 MB
Logical Content Uploaded: 7.0 MB
Compression Saved: 0.4 MB
Deduplication Saved: 7.0 MB
Number of Chunks Uploaded: 89
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
