[
https://issues.apache.org/jira/browse/FLINK-22241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler closed FLINK-22241.
------------------------------------
Resolution: Fixed
master: bcfaf0b475c18ac03b689ed8d9fd238a5b7c847e
> Log AllocationID instead of JobID when marking slot active failed
> -----------------------------------------------------------------
>
> Key: FLINK-22241
> URL: https://issues.apache.org/jira/browse/FLINK-22241
> Project: Flink
> Issue Type: Improvement
> Components: Runtime / Task
> Affects Versions: 1.13.0
> Reporter: Zhilong Hong
> Priority: Minor
> Fix For: 1.13.0
>
>
> For {{TaskExecutor#handleAcceptedSlotOffers}}, at present when slot failed to
> be marked as failed, the log prints JobID instead of AllocationID:
> {code:java}
> final String message = "Could not mark slot " + jobId + " active.";
> {code}
> I think it's better to print the AllocationID here like this:
> {code:java}
> final String message = "Could not mark slot " +
> acceptedSlot.getAllocationId() + " active.";
> {code}
> or
> {code:java}
> final String message = String.format("Could not mark slot %s active for job
> %s.", acceptedSlot.getAllocationId(), jobId);
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
