rmetzger commented on a change in pull request #15546:
URL: https://github.com/apache/flink/pull/15546#discussion_r612352287
##########
File path: tools/azure-pipelines/jobs-template.yml
##########
@@ -230,28 +223,24 @@ jobs:
./tools/azure-pipelines/free_disk_space.sh
echo "Installing required software"
- sudo apt-get install -y bc moreutils
displayName: Prepare E2E run
condition: not(eq(variables['SKIP'], '1'))
- script: ${{parameters.environment}} ./tools/ci/compile.sh
displayName: Build Flink
condition: not(eq(variables['SKIP'], '1'))
- - script: ${{parameters.environment}} FLINK_DIR=`pwd`/build-target
./tools/azure-pipelines/e2e_uploading_watchdog.sh
flink-end-to-end-tests/run-nightly-tests.sh
- timeoutInMinutes: 250
+ - script: ${{parameters.environment}} FLINK_DIR=`pwd`/build-target
./tools/azure-pipelines/uploading_watchdog.sh
flink-end-to-end-tests/run-nightly-tests.sh e2e
displayName: Run e2e tests
env:
IT_CASE_S3_BUCKET: $(SECRET_S3_BUCKET)
IT_CASE_S3_ACCESS_KEY: $(SECRET_S3_ACCESS_KEY)
IT_CASE_S3_SECRET_KEY: $(SECRET_S3_SECRET_KEY)
IT_CASE_GLUE_SCHEMA_ACCESS_KEY: $(SECRET_GLUE_SCHEMA_ACCESS_KEY)
IT_CASE_GLUE_SCHEMA_SECRET_KEY: $(SECRET_GLUE_SCHEMA_SECRET_KEY)
- condition: and(succeeded(),not(eq(variables['SKIP'], '1')))
+ condition: and(succeeded(), not(eq(variables['SKIP'], '1')))
# upload debug artifacts
- task: PublishPipelineArtifact@1
- condition: and(succeededOrFailed(), not(eq(variables['SKIP'], '1')),
not(eq(variables['ARTIFACT_DIR'], '')))
+ condition: and(not(eq(variables['SKIP'], '1')),
not(eq(variables['DEBUG_FILES_OUTPUT_DIR'], '')))
displayName: Upload Logs
inputs:
- targetPath: $(ARTIFACT_DIR)
- artifact: logs-${{parameters.stage_name}}-e2e
Review comment:
I added the stage name to the artifact name to avoid duplicate file
issues in the nightly CI profiles. It seems that the stage name is done again
based on timestamps, which has the risk of artifacts not being uploaded,
because they exist already (IIRC it has happened that files had exactly the
same timestamp (since builds are triggered at the same time)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
