KurtYoung commented on a change in pull request #15564:
URL: https://github.com/apache/flink/pull/15564#discussion_r612399552
##########
File path:
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/HiveCatalogTest.java
##########
@@ -78,4 +99,23 @@ public void testCreateHiveTable() {
prop.keySet().stream()
.noneMatch(k ->
k.startsWith(CatalogPropertiesUtil.FLINK_PROPERTY_PREFIX)));
}
+
+ @Test
+ public void testRetrieveFlinkProperties() throws
TableAlreadyExistException, DatabaseNotExistException, TableNotExistException {
+ ObjectPath hiveObjectPath = new ObjectPath(HiveCatalog.DEFAULT_DB,
"testRetrieveProperties");
+
+ Map<String, String> properties = new HashMap<>(new
FileSystem().path("/test_path").toProperties());
+
+ properties.put(CatalogPropertiesUtil.IS_GENERIC, String.valueOf(true));
+ properties.put("url", "jdbc:clickhouse://host:port/default");
Review comment:
set this property to a different value and also verify you can get this
property correctly?
##########
File path:
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/HiveCatalogTest.java
##########
@@ -78,4 +99,23 @@ public void testCreateHiveTable() {
prop.keySet().stream()
.noneMatch(k ->
k.startsWith(CatalogPropertiesUtil.FLINK_PROPERTY_PREFIX)));
}
+
+ @Test
+ public void testRetrieveFlinkProperties() throws
TableAlreadyExistException, DatabaseNotExistException, TableNotExistException {
+ ObjectPath hiveObjectPath = new ObjectPath(HiveCatalog.DEFAULT_DB,
"testRetrieveProperties");
+
+ Map<String, String> properties = new HashMap<>(new
FileSystem().path("/test_path").toProperties());
+
+ properties.put(CatalogPropertiesUtil.IS_GENERIC, String.valueOf(true));
+ properties.put("url", "jdbc:clickhouse://host:port/default");
+ properties.put("flink.url", "jdbc:clickhouse://host:port/default");
+
+ CatalogTable source = new CatalogTableImpl(schema, properties, null);
+
+ hiveCatalog.createTable(
+ hiveObjectPath, source, false);
Review comment:
unnecessary wrap here
##########
File path:
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/HiveCatalogTest.java
##########
@@ -78,4 +99,23 @@ public void testCreateHiveTable() {
prop.keySet().stream()
.noneMatch(k ->
k.startsWith(CatalogPropertiesUtil.FLINK_PROPERTY_PREFIX)));
}
+
+ @Test
+ public void testRetrieveFlinkProperties() throws
TableAlreadyExistException, DatabaseNotExistException, TableNotExistException {
Review comment:
throws Exception is enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
