AHeise commented on a change in pull request #15589:
URL: https://github.com/apache/flink/pull/15589#discussion_r612399861
##########
File path:
flink-tests/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterStopWithSavepointITCase.java
##########
@@ -152,7 +152,8 @@ private void
throwingExceptionOnCallbackWithoutRestartsHelper(final boolean term
// verifying that we actually received a synchronous checkpoint
assertTrue(syncSavepointId.get() > 0);
- assertThat(getJobStatus(), equalTo(JobStatus.FAILED));
+ assertThat(
Review comment:
Why did that work before? It's not clear to me why this is needed now.
##########
File path:
flink-tests/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterStopWithSavepointITCase.java
##########
@@ -81,6 +82,13 @@
@Rule public TemporaryFolder temporaryFolder = new TemporaryFolder();
+ @Rule
+ public Timeout timeout =
+ Timeout.builder()
+ .withTimeout(15, TimeUnit.SECONDS)
Review comment:
Make the timeout really big. It doesn't matter if it takes 1 or 10 min
on AZP to fail as long as it fails.
For manual tests, you adjust it anyways.
In general, timeouts on ITCases are quite error-prone on AZP when a heavy
test is also executed at the same time. I'd probably more go into the direction
of having no timeouts on AZP but just the general timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
